Kingdom: Encapsulation

Encapsulation is about drawing strong boundaries. In a web browser that might mean ensuring that your mobile code cannot be abused by other mobile code. On the server it might mean differentiation between validated data and unvalidated data, between one user's data and another's, or between data users are allowed to see and data that they are not.

Insecure Storage: Missing Encryption on Stored Private Media

Objective-C
Swift

Abstract

The identified method writes unencrypted data to iOS's photo album.

Explanation

Files saved to iOS's photo album are world-readable and can be accessed by any application on the device. This could allow an attacker to steal sensitive photos, such as those of checks used for mobile check deposits.

Example 1: The following code uses UIImageWriteToSavedPhotosAlbum to save images to the photo album:


- (void) imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary *)info
{
	// Access the uncropped image from info dictionary
	UIImage *image = [info objectForKey:UIImagePickerControllerOriginalImage];

  // Save image
  UIImageWriteToSavedPhotosAlbum(image, self, @selector(image:didFinishSavingWithError:contextInfo:), nil);

	...
}

References

[1] iOS Security Guide Apple

[2] Standards Mapping - Common Weakness Enumeration CWE ID 313, CWE ID 359, CWE ID 921

[3] Standards Mapping - Common Weakness Enumeration Top 25 2019 [4] CWE ID 200

[4] Standards Mapping - Common Weakness Enumeration Top 25 2020 [7] CWE ID 200

[5] Standards Mapping - Common Weakness Enumeration Top 25 2021 [20] CWE ID 200

[6] Standards Mapping - DISA Control Correlation Identifier Version 2 CCI-002475

[7] Standards Mapping - FIPS200 MP

[8] Standards Mapping - General Data Protection Regulation (GDPR) Insufficient Data Protection

[9] Standards Mapping - NIST Special Publication 800-53 Revision 4 SC-28 Protection of Information at Rest (P1)

[10] Standards Mapping - NIST Special Publication 800-53 Revision 5 SC-28 Protection of Information at Rest

[11] Standards Mapping - OWASP Application Security Verification Standard 4.0 2.6.3 Look-up Secret Verifier Requirements (L2 L3), 6.1.1 Data Classification (L2 L3), 6.1.2 Data Classification (L2 L3), 6.1.3 Data Classification (L2 L3), 6.2.1 Algorithms (L1 L2 L3), 8.1.6 General Data Protection (L3), 8.2.2 Client-side Data Protection (L1 L2 L3), 8.3.4 Sensitive Private Data (L1 L2 L3), 10.2.1 Malicious Code Search (L2 L3)

[12] Standards Mapping - OWASP Mobile 2014 M2 Insecure Data Storage

[13] Standards Mapping - OWASP Mobile 2024 M9 Insecure Data Storage

[14] Standards Mapping - OWASP Mobile Application Security Verification Standard 2.0 MASVS-STORAGE-1

[15] Standards Mapping - OWASP Top 10 2004 A8 Insecure Storage

[16] Standards Mapping - OWASP Top 10 2007 A8 Insecure Cryptographic Storage

[17] Standards Mapping - OWASP Top 10 2010 A7 Insecure Cryptographic Storage

[18] Standards Mapping - OWASP Top 10 2013 A6 Sensitive Data Exposure

[19] Standards Mapping - OWASP Top 10 2017 A3 Sensitive Data Exposure

[20] Standards Mapping - OWASP Top 10 2021 A02 Cryptographic Failures

[21] Standards Mapping - Payment Card Industry Data Security Standard Version 3.0 Requirement 6.5.3

[22] Standards Mapping - Payment Card Industry Data Security Standard Version 3.1 Requirement 6.5.3

[23] Standards Mapping - Payment Card Industry Data Security Standard Version 3.2 Requirement 6.5.3

[24] Standards Mapping - Payment Card Industry Data Security Standard Version 3.2.1 Requirement 6.5.3

[25] Standards Mapping - Payment Card Industry Data Security Standard Version 4.0 Requirement 6.2.4

[26] Standards Mapping - Payment Card Industry Software Security Framework 1.0 Control Objective 6.3 - Sensitive Data Protection, Control Objective 7 - Use of Cryptography

[27] Standards Mapping - Payment Card Industry Software Security Framework 1.1 Control Objective 6.3 - Sensitive Data Protection, Control Objective 7 - Use of Cryptography

[28] Standards Mapping - Payment Card Industry Software Security Framework 1.2 Control Objective 6.3 - Sensitive Data Protection, Control Objective 7 - Use of Cryptography

[29] Standards Mapping - SANS Top 25 2010 Porous Defenses - CWE ID 311

[30] Standards Mapping - SANS Top 25 2011 Porous Defenses - CWE ID 311

[31] Standards Mapping - Security Technical Implementation Guide Version 3.1 APP3210.1 CAT II, APP3310 CAT I, APP3340 CAT I

[32] Standards Mapping - Security Technical Implementation Guide Version 3.4 APP3210.1 CAT II, APP3340 CAT I

[33] Standards Mapping - Security Technical Implementation Guide Version 3.5 APP3210.1 CAT II, APP3340 CAT I

[34] Standards Mapping - Security Technical Implementation Guide Version 3.6 APP3210.1 CAT II, APP3340 CAT I

[35] Standards Mapping - Security Technical Implementation Guide Version 3.7 APP3210.1 CAT II, APP3340 CAT I

[36] Standards Mapping - Security Technical Implementation Guide Version 3.9 APP3210.1 CAT II, APP3340 CAT I

[37] Standards Mapping - Security Technical Implementation Guide Version 3.10 APP3210.1 CAT II, APP3340 CAT I

[38] Standards Mapping - Security Technical Implementation Guide Version 4.2 APSC-DV-002340 CAT II

[39] Standards Mapping - Security Technical Implementation Guide Version 4.3 APSC-DV-002340 CAT II

[40] Standards Mapping - Security Technical Implementation Guide Version 4.4 APSC-DV-002340 CAT II

[41] Standards Mapping - Security Technical Implementation Guide Version 4.5 APSC-DV-002340 CAT II

[42] Standards Mapping - Security Technical Implementation Guide Version 4.6 APSC-DV-002340 CAT II

[43] Standards Mapping - Security Technical Implementation Guide Version 4.7 APSC-DV-002340 CAT II

[44] Standards Mapping - Security Technical Implementation Guide Version 4.8 APSC-DV-002340 CAT II

[45] Standards Mapping - Security Technical Implementation Guide Version 4.9 APSC-DV-002340 CAT II

[46] Standards Mapping - Security Technical Implementation Guide Version 4.10 APSC-DV-002340 CAT II

[47] Standards Mapping - Security Technical Implementation Guide Version 4.11 APSC-DV-002340 CAT II

[48] Standards Mapping - Security Technical Implementation Guide Version 4.1 APSC-DV-002340 CAT II

[49] Standards Mapping - Security Technical Implementation Guide Version 5.1 APSC-DV-002340 CAT II

[50] Standards Mapping - Security Technical Implementation Guide Version 5.2 APSC-DV-002340 CAT II

[51] Standards Mapping - Security Technical Implementation Guide Version 5.3 APSC-DV-002340 CAT II

[52] Standards Mapping - Web Application Security Consortium Version 2.00 Information Leakage (WASC-13)

desc.structural.objc.insecure_storage_missing_encryption_on_stored_private_media

Abstract

The identified method writes unencrypted data to iOS's photo album.

Explanation


func imagePickerController(picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [NSObject : AnyObject]) {
    if let pickedImage = info[UIImagePickerControllerOriginalImage] as? UIImage {
        imageView.contentMode = .ScaleAspectFit
        imageView.image = pickedImage
    }

    // Save image
    UIImageWriteToSavedPhotosAlbum(pickedImage!, self, nil, nil)

    dismissViewControllerAnimated(true, completion: nil)
}